viirya commented on code in PR #233:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/233#discussion_r1540264252
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -219,21 +271,146 @@ object CometShuffleExchangeExec extends
ShimCometShuffleExchangeExec {
newPartitioning: Partitioning,
serializer: Serializer,
writeMetrics: Map[String, SQLMetric]): ShuffleDependency[Int,
InternalRow, InternalRow] = {
- val sparkShuffleDep = ShuffleExchangeExec.prepareShuffleDependency(
- rdd,
- outputAttributes,
- newPartitioning,
- serializer,
- writeMetrics)
+ val part: Partitioner = newPartitioning match {
Review Comment:
We call `ShuffleExchangeExec.prepareShuffleDependency` before.
But now we need to overwrite `needToCopyObjectsBeforeShuffle` which is a
private method in Spark. So we need to copy the code of
`ShuffleExchangeExec.prepareShuffleDependency` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
