assignUser commented on code in PR #410: URL: https://github.com/apache/arrow-nanoarrow/pull/410#discussion_r1540368817
########## ci/scripts/build-arrow-cpp-minimal.sh: ########## @@ -0,0 +1,67 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Builds a minimal Arrow C++ version required for running nanoarrow tests + +set -e +set -o pipefail + +case $# in + 2) ARROW_CPP_VERSION="$1" + ARROW_CPP_INSTALL_DIR="$2" + ;; + *) echo "Usage:" + echo " Build and install Arrow C++:" + echo " $0 <version> <install dir>" + exit 1 + ;; +esac + +# Allow other cmake (e.g., cmake3 on centos7) +if [ -z "$CMAKE_BIN" ]; then + CMAKE_BIN=cmake +fi + +# Ensure install directory exists and is absolute +if [ ! -d "${ARROW_CPP_INSTALL_DIR}" ]; then + mkdir -p "${ARROW_CPP_INSTALL_DIR}" +fi + +ARROW_CPP_INSTALL_DIR="$(cd "${ARROW_CPP_INSTALL_DIR}" && pwd)" + +ARROW_CPP_SCRATCH_DIR="arrow-cpp-build-${ARROW_CPP_VERSION}" + +mkdir "${ARROW_CPP_SCRATCH_DIR}" +pushd "${ARROW_CPP_SCRATCH_DIR}" + +curl https://dlcdn.apache.org/arrow/arrow-${ARROW_CPP_VERSION}/apache-arrow-${ARROW_CPP_VERSION}.tar.gz | \ Review Comment: The canonical url uses `closer.lua` e.g. `https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-15.0.2/apache-arrow-15.0.2.tar.gz` Ideally you should also check the sha but as this is only used for testing it's not critical. ########## .github/workflows/build-and-test-ipc.yaml: ########## @@ -51,36 +51,46 @@ jobs: NANOARROW_ARROW_TESTING_DIR: '${{ github.workspace }}/arrow-testing' steps: - - name: Checkout repo - uses: actions/checkout@v3 - with: - fetch-depth: 0 Review Comment: Yeah I don't see you doing anything that would require a full checkout (e.g. changing branch/using tags etc.) :+1: ########## .github/workflows/build-and-test-device.yaml: ########## @@ -50,27 +50,12 @@ jobs: NANOARROW_ARROW_TESTING_DIR: '${{ github.workspace }}/arrow-testing' steps: - - name: Checkout repo - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - - name: Checkout arrow-testing - uses: actions/checkout@v3 - with: - repository: apache/arrow-testing - fetch-depth: 0 - path: arrow-testing + - uses: actions/checkout@v4 - - name: Install dependencies + - name: Install memcheck dependencies + if: matrix.config.label == 'default-build' run: | - sudo apt-get update - sudo apt install -y -V ca-certificates lsb-release wget cmake valgrind - wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb - sudo apt-get install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb - sudo apt-get update - sudo apt-get install -y -V libarrow-dev - rm apache-arrow-apt-*.deb Review Comment: You are removing the installation of arrow here but I don't see the cache/build being added? Was it not needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
