AlenkaF commented on code in PR #40803:
URL: https://github.com/apache/arrow/pull/40803#discussion_r1540603817
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -276,7 +284,8 @@ struct ConvertColumnsToTensorVisitor {
};
template <typename DataType>
-inline void ConvertColumnsToTensor(const RecordBatch& batch, uint8_t* out) {
+inline void ConvertColumnsToTensor(const RecordBatch& batch, uint8_t* out,
+ bool null_to_nan) {
Review Comment:
Oh no, of course. No need for it anymore due to the visitor pattern. Will
remove!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
