Tom-Newton commented on code in PR #40838:
URL: https://github.com/apache/arrow/pull/40838#discussion_r1541935615
##########
cpp/src/arrow/filesystem/azurefs.h:
##########
@@ -264,15 +264,35 @@ class ARROW_EXPORT AzureFileSystem : public FileSystem {
Status CreateDir(const std::string& path, bool recursive) override;
+ /// \brief Delete a directory and its contents recursively.
+ ///
+ /// Atomicity is guaranteed only on Hierarchical Namespace Storage accounts.
Status DeleteDir(const std::string& path) override;
+ /// \brief Non-atomically deletes the contents of a directory.
+ ///
+ /// This function can return a bad Status after only partially deleting the
+ /// contents of the directory.
Status DeleteDirContents(const std::string& path, bool missing_dir_ok)
override;
+ /// \brief Deletion of all the containers in the storage account (not
+ /// implemented for safety reasons).
+ ///
+ /// \return Status::NotImplemented
Status DeleteRootDirContents() override;
+ /// \brief Deletes a file.
+ ///
+ /// Supported on both flat namespace and Hierarchical Namespace storage
+ /// accounts. A check is made to guarantee the parent directory doesn't
+ /// disappear after the blob is deleted and while this operation is running,
Review Comment:
Is this referring to flat namespace accounts only? I can't imagine a
hierarchical namespace directory disappearing when a file is deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
