danepitkin commented on issue #40775:
URL: https://github.com/apache/arrow/issues/40775#issuecomment-2024146469

   I think some of the performance benchmarks might be configured incorrectly. 
A few Java benchmarks use `Level.Invocation` when setting up and tearing down, 
including WriteChannelBenchmark:
   
   
https://github.com/apache/arrow/blob/2146ab10e653f927a6e92d29ee0910f30f4cb996/java/performance/src/test/java/org/apache/arrow/vector/ipc/WriteChannelBenchmark.java#L58-L69
   
   According to the javadocs, `Level.Invocation` has dragons:
   
   
https://javadoc.io/static/org.openjdk.jmh/jmh-core/1.1.1/org/openjdk/jmh/annotations/Level.html#Invocation
   
   `Level.Invocation` is only for benchmarks that take >=1ms. Our benchmark is 
zeroing out an unaligned 8 byte buffer.. Running the benchmark shows billions 
of these buffer alignment operations in the benchmark, which makes me think 
there is some race condition happening on setup/teardown causing a near 
infinite loop. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to