ZhangHuiGui commented on code in PR #40688:
URL: https://github.com/apache/arrow/pull/40688#discussion_r1542341993
##########
cpp/src/arrow/compute/expression.cc:
##########
@@ -874,7 +874,7 @@ Result<Expression> FoldConstants(Expression expr) {
}
}
- if (call->function_name == "and_kleene") {
+ if (call->function_name == "and_kleene" || call->function_name ==
"and") {
Review Comment:
Oh, my fault. In SQL scenarios, Kleene-related logical operators are
commonly used. Optimizing for Kleene operators is sufficient in most cases, and
it may not be necessary to optimize for non-Kleene operators. This is not a
universally applicable scenario within the expression system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]