mustafasrepo commented on PR #9719: URL: https://github.com/apache/arrow-datafusion/pull/9719#issuecomment-2026733046
> Thanks @mustafasrepo , I double-checked the results and it meet the requirements. I actually have one question, why we could still get the proper answer with eliminating the upper ProjectionExec?(I think it is optimized since another logical plan optimization would eliminate the same Projection) I think it is ready to be merged now. Also, I think we could use similar way to track Aggregate, I could make an extra ticket here and solve it in the coming PR. Exactly, the `optimize_projections` rule (for `LogicalPlan`) removes the unnecessary `LogicalPlan::Projection`s from the plan if those projections have same input and same output schema. In this example, this is the case also. `LogicalPlan::window` has already desired schema for the user input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
