jayzhan211 commented on issue #8708: URL: https://github.com/apache/arrow-datafusion/issues/8708#issuecomment-2027282612
I have another question. I think our goal for the aggregate function is similar to `functions`. we will move them into separate create. If we need to avoid importing `physical-expr`. It seems we need to move some struct from `physical-expr` to `expr`, like `PhysicalExpr` and `pub type LexOrdering = Vec<PhysicalSortExpr>;` https://github.com/apache/arrow-datafusion/blob/3eeb108125b35424baac39dd20ba88433b347419/datafusion/physical-expr/src/aggregate/first_last.rs#L44-L45 But, does moving `PhysicalExpr` to `datafusion_expr` make sense? 😕 Where/When should be convert `expr` to `physical-expr` like `sort_exprs` to `LexOrdering`. Should we go through the whole process in `aggregate-functions` crate like what `functions` do or we should seperate `logical-expr` and `physical-expr` for `aggregate-functions` and find a way to link between them (convert from logical-expr to physical-expr)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
