wgtmac commented on code in PR #40885:
URL: https://github.com/apache/arrow/pull/40885#discussion_r1544570271
##########
cpp/src/parquet/column_reader.h:
##########
@@ -318,10 +318,12 @@ class PARQUET_EXPORT RecordReader {
/// @param read_dictionary True if reading directly as Arrow
dictionary-encoded
/// @param read_dense_for_nullable True if reading dense and not leaving
space for null
/// values
+ /// @param read_boolean_as_bitmap True if reading boolean as bitmap.
static std::shared_ptr<RecordReader> Make(
const ColumnDescriptor* descr, LevelInfo leaf_info,
::arrow::MemoryPool* pool = ::arrow::default_memory_pool(),
- bool read_dictionary = false, bool read_dense_for_nullable = false);
+ bool read_dictionary = false, bool read_dense_for_nullable = false,
Review Comment:
These parameters are enough to have a new RecordReaderOptions, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
