gruuya commented on PR #9800: URL: https://github.com/apache/arrow-datafusion/pull/9800#issuecomment-2027400317
> # Benchmark results > Benchmarks comparing [179179c](https://github.com/apache/arrow-datafusion/commit/179179c0b719a7f9e33d138ab728fdc2b0e1e1d8) (main) and [9bd30ea](https://github.com/apache/arrow-datafusion/commit/9bd30ea74264feec521a6b740261cfaecfc19e43) (PR) > > ``` > Comparing 179179c and 9bd30ea > Note: Skipping /home/runner/work/arrow-datafusion/arrow-datafusion/benchmarks/results/179179c/tpch_mem_sf1.json as /home/runner/work/arrow-datafusion/arrow-datafusion/benchmarks/results/9bd30ea/tpch_mem_sf1.json does not exist > Note: Skipping /home/runner/work/arrow-datafusion/arrow-datafusion/benchmarks/results/179179c/tpch_sf1.json as /home/runner/work/arrow-datafusion/arrow-datafusion/benchmarks/results/9bd30ea/tpch_sf1.json does not exist > Note: Skipping /home/runner/work/arrow-datafusion/arrow-datafusion/benchmarks/results/179179c/tpch_sf10.json as /home/runner/work/arrow-datafusion/arrow-datafusion/benchmarks/results/9bd30ea/tpch_sf10.json does not exist > ``` So what seem to have happened here is that the step benchmarking the PR changes uses it's version of the `benchmarks/bench.sh` file, and that is different from the one on main now due to this https://github.com/apache/arrow-datafusion/blob/179179c0b719a7f9e33d138ab728fdc2b0e1e1d8/benchmarks/bench.sh#L317 I needed to add a distinction between the results since previously SF1/SF10 would overwrite the same file. So the resolution is just to rebase on/merge from main and re-run the benches again. 👀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
