laurentgo opened a new pull request, #40908:
URL: https://github.com/apache/arrow/pull/40908

   ### Rationale for this change
   
   FlightSQL JDBC Driver does not shade slfj4 api which may come into conflict 
into the version used by an application. If the application uses slf4j 1.x, it 
may cause the application slf4j backend to not be loaded properly.
   
   The change configured maven-shade-plugin to also shade slf4j-api. To make 
sure log messages are still visible, slf4j-jdk14 is included as well so that 
all messages will be redirected to java.util.logging framework. The application 
can use jul-to-slf4j adapter to redirect log messages back to slf4j.
   
   ### What changes are included in this PR?
   
   Overrides Driver#getParentLogger() to return the root logger for the JDBC 
driver (which is `org.apache.arrow.driver.jdbc`). To make sure shaded 
dependencies loggers are included as well, change relocation from cfjd.  to 
org.apache.arrow.driver.jdbc.shaded. (or oaadj for native libraries)
   
   ### Are these changes tested?
   
   Verifying that slf4j-api is shaded along with the other relocation changes 
are covered by `ITDriverJarValidation`
   
   ### Are there any user-facing changes?
   
   Yes. Driver will not expose directly slf4j api and the logger names for the 
shaded dependencies have been updated. For applications which were relying on 
configuring directly a slf4j logging backend for the driver, they may need to 
include `org.slf4j:slf4-api` and `org.slf4j:jul-to-slf4j` for logging 
configuration to work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to