alamb commented on code in PR #9865: URL: https://github.com/apache/arrow-datafusion/pull/9865#discussion_r1545339750
########## dev/depcheck/README.md: ########## @@ -0,0 +1,26 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +This directory contains a tool that ensures there are no circular dependencies +in the DataFusion codebase. + +Specifically, it checks that no create's tests depend on another crate which +depends on the first, which prevents publishing to crates.io, for exmample Review Comment: ```suggestion depends on the first, which prevents publishing to crates.io, for example ``` ########## .github/workflows/rust.yml: ########## @@ -164,6 +164,25 @@ jobs: - name: Verify Working Directory Clean run: git diff --exit-code + depcheck: + name: circular dependency check + needs: [ linux-build-lib ] + runs-on: ubuntu-latest + container: + image: amd64/rust + steps: + - uses: actions/checkout@v4 + with: + submodules: true + - name: Setup Rust toolchain + uses: ./.github/actions/setup-builder + with: + rust-version: stable + - name: Check dependencies + run: | + cd dev/depcheck + cargo run Review Comment: Note this check was previously covered by `cargo test -p datafusion` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
