alamb commented on code in PR #9872:
URL: https://github.com/apache/arrow-datafusion/pull/9872#discussion_r1545350387
##########
datafusion/sqllogictest/test_files/order.slt:
##########
@@ -527,9 +527,10 @@ Sort: atan_c11 ASC NULLS LAST
----TableScan: aggregate_test_100 projection=[c11]
physical_plan
SortPreservingMergeExec: [atan_c11@0 ASC NULLS LAST]
---ProjectionExec: expr=[atan(c11@0) as atan_c11]
-----RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1
-------CsvExec: file_groups={1 group:
[[WORKSPACE_ROOT/testing/data/csv/aggregate_test_100.csv]]}, projection=[c11],
output_ordering=[c11@0 ASC NULLS LAST], has_header=true
+--SortExec: expr=[atan_c11@0 ASC NULLS LAST]
Review Comment:
This test seems to show a regression (there is now a sort in it).
I wonder if the issue is that you need to specify montononicity (which is
now possible after https://github.com/apache/arrow-datafusion/pull/9869 from
@tinfoil-knight )?
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -37,16 +37,8 @@ use strum_macros::EnumIter;
#[derive(Debug, Clone, PartialEq, Eq, Hash, EnumIter, Copy)]
pub enum BuiltinScalarFunction {
// math functions
- /// atan
- Atan,
/// atan2
Atan2,
Review Comment:
any particular reason that you did not migrate Atan2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
