suremarc commented on code in PR #9593: URL: https://github.com/apache/arrow-datafusion/pull/9593#discussion_r1545517463
########## datafusion/sqllogictest/test_files/parquet.slt: ########## @@ -169,6 +171,38 @@ SELECT min(date_col) FROM test_table; ---- 1970-01-02 +# Clean up +statement ok +DROP TABLE test_table; + +# Do one more test, but order by numeric columns: +# This is to exercise file group sorting, which uses file-level statistics +# DataFusion doesn't currently support string column statistics +statement ok +CREATE EXTERNAL TABLE test_table ( + int_col INT NOT NULL, + string_col TEXT NOT NULL, + bigint_col BIGINT NOT NULL, + date_col DATE NOT NULL +) +STORED AS PARQUET +WITH HEADER ROW +WITH ORDER (int_col ASC NULLS LAST, bigint_col ASC NULLS LAST) +LOCATION 'test_files/scratch/parquet/test_table'; + +# Check output plan again, expect an "output_ordering" clause in the physical_plan -> ParquetExec: +# After https://github.com/apache/arrow-datafusion/pull/9593 this should not require a sort. Review Comment: Yeah I guess the wording is confusing since it implies the test existed before this PR. Either way I'm going to make a new sqllogictest so I'll rewrite this comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
