advancedxy commented on code in PR #238:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/238#discussion_r1546267335
##########
common/src/main/java/org/apache/comet/parquet/TypeUtil.java:
##########
@@ -196,7 +196,9 @@ && isUnsignedIntTypeMatched(logicalTypeAnnotation, 64)) {
|| canReadAsBinaryDecimal(descriptor, sparkType)
|| sparkType == DataTypes.BinaryType
// for uuid, since iceberg maps uuid to StringType
- || sparkType == DataTypes.StringType) {
+ || sparkType == DataTypes.StringType
+ && descriptor.getPrimitiveType().getLogicalTypeAnnotation()
+ instanceof
LogicalTypeAnnotation.UUIDLogicalTypeAnnotation) {
Review Comment:
hmmm, one related question: is Iceberg reader supported in Comet yet?
It seems like that Comet doesn't support Iceberg reader yet? Once it's
added, we can test this then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
