alamb commented on code in PR #9889:
URL: https://github.com/apache/arrow-datafusion/pull/9889#discussion_r1546349462
##########
datafusion/functions/src/math/mod.rs:
##########
@@ -39,6 +37,7 @@ make_math_unary_udf!(AtanhFunc, ATANH, atanh, atanh,
Some(vec![Some(true)]));
make_math_unary_udf!(AsinhFunc, ASINH, asinh, asinh, Some(vec![Some(true)]));
make_math_unary_udf!(AcoshFunc, ACOSH, acosh, acosh, Some(vec![Some(true)]));
make_math_unary_udf!(AtanFunc, ATAN, atan, atan, Some(vec![Some(true)]));
+make_math_binary_udf!(Atan2, ATAN2, atan2, atan2, Some(vec![Some(true)]));
Review Comment:
❤️
##########
datafusion/functions/src/macros.rs:
##########
@@ -251,7 +251,112 @@ macro_rules! make_math_unary_udf {
};
}
-#[macro_export]
+/// Macro to create a binary math UDF.
+///
+/// A binary math function takes an argument of type Float32 or Float64,
+/// applies a binary floating function to the argument, and returns a value of
the same type.
Review Comment:
```suggestion
/// A binary math function takes two arguments of types Float32 or Float64,
/// applies a binary floating function to the argument, and returns a value
of the same type.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
