zeroshade commented on code in PR #40889:
URL: https://github.com/apache/arrow/pull/40889#discussion_r1546434319
##########
go/arrow/flight/flightsql/driver/utils_test.go:
##########
@@ -123,4 +125,10 @@ func Test_fromArrowType(t *testing.T) {
tf(t, 14, time.Date(1970, 1, 1, 12, 0, 0, 0, time.UTC)) // "f15-ts_us"
tf(t, 15, testTime.In(time.UTC).Truncate(24*time.Hour)) // "f16-d64"
tf(t, 16, time.Duration(24*time.Hour+time.Second)) // "f17-dti"
+ // according to
+ //
https://github.com/apache/arrow/blob/50ca7a76d38e6ecf19589bc44f46bffd1db0d4c8/format/Schema.fbs#L420-L435
+ // the default "TimeUnit" for an arrow.Duration is in microseconds but
golang
+ // Durations are int64 nanoseconds so we verify here that the
+ // array.Duration(1) we create above shows up as a 1000 nanoseconds
+ tf(t, 17, time.Duration(1000)) // "f18-duration_ms"
Review Comment:
the comment should be `f18-duration_us`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
