domoritz commented on PR #40892: URL: https://github.com/apache/arrow/pull/40892#issuecomment-2030786983
We do construct dates for DateMillisecond already so I figured it would make sense to do the same for TimestampMillisecond. > IIRC constructing date instances is relatively expensive esp. if using custom locales, so users should opt-in to that behavior if they need it? I did not measure it but wit surprises me a bit since I expected it to just be a lightweight wrapper around timestamps. I'd be okay with just retuning numbers to be fast but also to introduce an iterator for vectors that returns convenient types in JS that may be slower but easier to work with (in a follow up PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
