pitrou commented on code in PR #40484: URL: https://github.com/apache/arrow/pull/40484#discussion_r1547807171
########## cpp/src/arrow/acero/schema_util.h: ########## @@ -22,8 +22,8 @@ #include <string> #include <vector> -#include "arrow/compute/light_array.h" // for KeyColumnMetadata -#include "arrow/type.h" // for DataType, FieldRef, Field and Schema +#include "arrow/compute/light_array_internal.h" // for KeyColumnMetadata Review Comment: 1. this is including an internal header from a non-internal header 2. fortunately, `KeyColumnMetadata` doesn't seem used at all here, so we can just remove this include? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
