alamb commented on code in PR #9916:
URL: https://github.com/apache/arrow-datafusion/pull/9916#discussion_r1548483839
##########
datafusion/common/src/table_reference.rs:
##########
@@ -131,7 +131,7 @@ impl TableReference {
/// As described on [`TableReference`] this does *NO* parsing at
/// all, so "Foo.Bar" stays as a reference to the table named
/// "Foo.Bar" (rather than "foo"."bar")
- pub fn bare(table: &str) -> TableReference {
+ pub fn bare(table: impl Into<Arc<str>>) -> TableReference {
Review Comment:
This PR tests the theory that
```rust
pub fn bare(table: impl Into<Arc<str>>) -> TableReference {
```
will be faster than
```rust
pub fn bare(table: &str) -> TableReference {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
