laurentgo commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2033219148

   > Install docker/docker-compose, for archery
   The issue is actually for the `Java/AMD64 JDK8 Ubuntu` check
   
   > Do we need to shade in -core? I had thought the point of having the split 
was not to shade
   I have no idea to be honest, I see a lot of shading in 
`flight-sql-jdbc-core` and `vector` but not sure if those shaded artifacts are 
actually used or not, and for what purpose. I would argue that 
`maven-shade-modules` should only be used in leaf modules as having 
dependencies between modules in the same reactor may cause weird behavior (the 
main one being that the classes and pom.xml being may change based on the maven 
invocation)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to