pitrou commented on PR #40857: URL: https://github.com/apache/arrow/pull/40857#issuecomment-2033794599
Hello, There are two problems with this PR: 1. the possible values should reflect the allowed values for `ARROW_USER_SIMD_LEVEL` (which "neon" is not part of) 2. it broke the [arm64 wheel tests](https://github.com/ursacomputing/crossbow/actions/runs/8526875367/job/23357055648#step:10:791): ``` =================================== FAILURES =================================== ______________________________ test_runtime_info _______________________________ def test_runtime_info(): info = pa.runtime_info() assert isinstance(info, pa.RuntimeInfo) possible_simd_levels = ('none', 'sse4_2', 'avx', 'avx2', 'avx512') > assert info.simd_level in possible_simd_levels E AssertionError: assert 'neon' in ('none', 'sse4_2', 'avx', 'avx2', 'avx512') E + where 'neon' = RuntimeInfo(simd_level='neon', detected_simd_level='neon').simd_level ``` Can this perhaps be reverted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
