jayzhan211 opened a new issue, #9921:
URL: https://github.com/apache/arrow-datafusion/issues/9921

                 I see -- it seems like the issue is that the accumulator 
implementation requires PhysicalSortExpr.
   
   To pull the code into its own crate maybe we could pull out the relevant 
pieces of `datafusion-physical-expr` into `datafusion-physical-core` or 
something (as a follow on PR)
   
   _Originally posted by @alamb in 
https://github.com/apache/arrow-datafusion/pull/9874#discussion_r1546829352_
               
   We want to move aggregate function to `aggreagate-functions` crate but avoid 
importing whole `physical-expr` crate. Therefore, we need  to move 
PhysicalSortExpr for ordering, and of course PhysicalExpr to 
`physical-expr-core`. Then, we can import it only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to