alamb commented on code in PR #9923:
URL: https://github.com/apache/arrow-datafusion/pull/9923#discussion_r1549669543
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -1430,12 +1430,12 @@ impl TableProvider for DataFrameTableProvider {
Some(&self.plan)
}
- fn supports_filter_pushdown(
+ fn supports_filters_pushdown(
Review Comment:
Switches to using the non deprecated but very similarly named API
##########
datafusion/core/src/datasource/provider.rs:
##########
@@ -154,28 +158,31 @@ pub trait TableProvider: Sync + Send {
limit: Option<usize>,
) -> Result<Arc<dyn ExecutionPlan>>;
- /// Tests whether the table provider can make use of a filter expression
- /// to optimise data retrieval.
- #[deprecated(since = "20.0.0", note = "use supports_filters_pushdown
instead")]
Review Comment:
This has been deprecated for quite a while
##########
datafusion/core/src/datasource/provider.rs:
##########
@@ -154,28 +158,31 @@ pub trait TableProvider: Sync + Send {
limit: Option<usize>,
) -> Result<Arc<dyn ExecutionPlan>>;
- /// Tests whether the table provider can make use of a filter expression
- /// to optimise data retrieval.
- #[deprecated(since = "20.0.0", note = "use supports_filters_pushdown
instead")]
- fn supports_filter_pushdown(
- &self,
- _filter: &Expr,
- ) -> Result<TableProviderFilterPushDown> {
- Ok(TableProviderFilterPushDown::Unsupported)
- }
-
- /// Tests whether the table provider can make use of any or all filter
expressions
- /// to optimise data retrieval.
- /// Note: the returned vector much have the same size as the filters
argument.
- #[allow(deprecated)]
+ /// Specify if DataFusion should provide filter expressions to the
Review Comment:
I tried to improve the docs about what this was doing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
