tustvold commented on code in PR #5541:
URL: https://github.com/apache/arrow-rs/pull/5541#discussion_r1550174382
##########
arrow-array/src/builder/fixed_size_list_builder.rs:
##########
@@ -248,9 +325,37 @@ mod tests {
}
#[test]
- fn test_fixed_size_list_array_builder_finish_cloned() {
+ fn test_fixed_size_list_array_builder_with_field() {
+ let builder = make_list_builder(false, false);
Review Comment:
The logic we apply for FixedSizeList and StructArray elsewhere is to permit
"masked" nulls, this is because a null must always take up space. I am not sure
if we want to replicate this logic here.
See
https://docs.rs/arrow-array/latest/arrow_array/array/struct.FixedSizeListArray.html#method.try_new
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
