kou commented on PR #40956: URL: https://github.com/apache/arrow/pull/40956#issuecomment-2035636219
Ah, sorry for not sharing how to implement this in https://lists.apache.org/thread/hm7cbrkggomhx7nxdzr5xkrmkrztmmwo ... How about using `git tag -a apache-arrow-X.Y.Z-rcN`, `git push apache apache-arrow-X.Y.Z-rcN` and GitHub Actions for the RC tag? We can detect whether this push is for tag or commit by `if: github.ref_type == 'tag'`. See also: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context If this push is for tag, we can download the built `.mltbx` file and upload it to GitHub Releases by GitHub Actions. We can't sign by GitHub Actions. So we need to sign on local later. We can do it by a release script. This is a workflow what arrow-adbc already uses. See also: 1. `git tag`: https://github.com/apache/arrow-adbc/blob/a35fae0f11c29b6207c1361986d7900441562d64/dev/release/01-prepare.sh#L76 2. Upload artifacts to GitHub Releases by GitHub Actions: https://github.com/apache/arrow-adbc/blob/a35fae0f11c29b6207c1361986d7900441562d64/.github/workflows/packaging.yml#L945-L999 3. Download artifacts from GitHub Releases, sign them and upload to GitHub Releases: https://github.com/apache/arrow-adbc/blob/main/dev/release/02-sign.sh 4. Change the associated tag of GitHub Releases from `apache-arrow-adbc-X.Y.Z-rcN` to `apache-arrow-adbc-X.Y.Z` after a vote is passed: https://github.com/apache/arrow-adbc/blob/main/dev/release/post-02-binary.sh * I want to use different approach in apache/arrow for this. I don't want to change existing GitHub Releases for this. I want to create a new GitHub Releases for `apache-arrow-X.Y.Z` instead of reusing a GitHub Releases for `apache-arrow-X.Y.Z-rcN`. * arrow-flight-sql-postgresql uses the different approach: https://github.com/apache/arrow-flight-sql-postgresql/blob/main/.github/workflows/release.yaml * `git tag -a apache-arrow-X.Y.Z` and `git push apache apache-arrow-X.Y.Z` trigger this GitHub Actions workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
