paleolimbot commented on PR #409: URL: https://github.com/apache/arrow-nanoarrow/pull/409#issuecomment-2036079003
Apologies for the two additional changes, but: - After adding the `DeviceType`, it was pretty clear that the `CDevice` was never going to get a `Device` wrapper in not-Cython. Interacting with the device is something that mostly happens in the classes that live in Cython, and the only thing that anybody needs to know about it otherwise is to print it or know if it's the CPU or not. For the other classes there's some payoff to wrapping them in Python (better IDE documentation + completion, iteration time), but the `Device` doesn't benefit from any of those. - The discussion in https://github.com/apache/arrow/issues/40801 suggested that the device_id for the CPU device should be -1 instead of 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
