ZhangHuiGui commented on PR #40998: URL: https://github.com/apache/arrow/pull/40998#issuecomment-2036370421
> Any way is it hard to have a unittest here? Yes, there are some very special cases need to be constructed here: 1. The col-id order of key-columns in the constructed rowtable needs to change after FromColumnMetadataVector. That is, we need to construct columns that can support column-sort. This is easy. 2. The key problem is that entering columns with nulls requires a difference in the following codes when we use the current col_id or the reversed col_id in rowtable: https://github.com/apache/arrow/blob/36ed0328b43ca39533e58a889f8e091d1f1ca7dc/cpp/src/arrow/compute/row/compare_internal.cc#L81-L90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
