nevi-me commented on pull request #9413: URL: https://github.com/apache/arrow/pull/9413#issuecomment-778749098
> For further simplification, we could maybe remove the `offset` parameter here, I see it is 0 in all usages of this PR. If we leave it in, we should add a test with a non-zero offset, as I'm not convinced the logic is correct. @jhorstmann I went the opposite way to you on this. I was relying on my intuition; but perhaps I need to come with a test case to validate my thinking on whether we should leave the option of taking an offset open. @jorgecarleitao we can keep the current behaviour for now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
