kou commented on code in PR #40067:
URL: https://github.com/apache/arrow/pull/40067#discussion_r1551783508
##########
cpp/src/arrow/util/value_parsing.h:
##########
@@ -163,6 +166,20 @@ struct StringConverter<DoubleType> {
const char decimal_point;
};
+template <>
+struct StringConverter<HalfFloatType> {
Review Comment:
Ah, I thought tests added to `scalar_cast_test.cc` cover this.
I missed that we have `value_parsing_test.cc`.
@ClifHouck Could you add tests for this to `value_parsing_test.cc` as a
follow-up task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
