domoritz commented on code in PR #40960:
URL: https://github.com/apache/arrow/pull/40960#discussion_r1552376861
##########
js/src/type.ts:
##########
@@ -333,23 +333,47 @@ export class Decimal extends DataType<Type.Decimal> {
/** @ignore */
export type Dates = Type.Date | Type.DateDay | Type.DateMillisecond;
/** @ignore */
-export interface Date_<T extends Dates = Dates> extends DataType<T> { TArray:
Int32Array; TValue: Date; ArrayType: TypedArrayConstructor<Int32Array> }
+type DateType = {
+ [Type.Date]: { TArray: Int32Array | BigInt64Array };
Review Comment:
`Type.Date` is the generic one that can be one of the other two. It's the
actual physical type (8 in the flatbuffers) while the other two are the actual
types people can instantiate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
