jbonofre commented on PR #40939: URL: https://github.com/apache/arrow/pull/40939#issuecomment-2038994467
Hi @jduo ! > Some of the code in odbc_impl should be updated to use the same naming conventions as the arrow project (eg ODBCConnection -> odbc_connection). Yes, I'm doing that (that's why the PR is still a draft). > > This covers the flightsql-odbc repo, but there is additional code needed for the ODBC entry points to build a functional driver. That was in warpdrive, but that code isn't Apache-compatible. Yes, locally I fixed/updated it, but I'm looking for alternative. > > Need to add the license for whereami to the Arrow project itself. I'm checking if we can't find an alternative, else I will update `NOTICE` file. > > Are the separate brewfile and vcpkg.json necessary or can this utilize the ones already at the top-level? Yes, that's the plan, I'm doing in two steps: fixing the build and integrating in the Arrow ecosystem. > > Should the top-level CMakeLists now include the driver build? Or is that on hold as part of the donation process? Agree, same the same as for `brewfile`/`vcpkg.json`: I'm doing that in two steps. I will push new changes to this PR and "remove" the draft state as soon as it's clean to review (build ok, etc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
