viirya commented on code in PR #226:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/226#discussion_r1552974787
##########
core/src/execution/datafusion/spark_hash.rs:
##########
@@ -165,7 +165,6 @@ macro_rules! hash_array_primitive_float {
} else {
*hash = spark_compatible_murmur3_hash((*value as
$ty).to_le_bytes(), *hash);
}
- *hash = spark_compatible_murmur3_hash((*value as
$ty).to_le_bytes(), *hash);
Review Comment:
Yea, I think it should be good to create a separate PR for this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
