joemarshall commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1554370483
##########
python/setup.py:
##########
@@ -133,8 +143,68 @@ def run(self):
'bundle the Arrow C++ headers')] +
_build_ext.user_options)
+ def get_arrow_build_options(self):
Review Comment:
@pitrou finally getting round to messing with this now c++ is in - I
discover that there is actually an official way to query arrow options as JSON.
I'll look at that next.
The reason for needing this for pyodide is that pyodide builds everything in
an isolated environment which loses the environment variables that are passed
in to set these things up. It's either that or make a file to load settings
in, but even if one supported a settings file it would be good to default to
building a pyarrow with the same options as the linked in libarrow.
@kou - I think it has to be done before the cmake build is run because the
value of the options alters some things in setup.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
