jonahgao opened a new pull request, #9975:
URL: https://github.com/apache/arrow-datafusion/pull/9975

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #9932.
   
   ## Rationale for this change
   In a `GenericListArray`, the data in the `values` corresponding to a null 
list may not be empty; it can be any data.
   ```rust
   pub struct GenericListArray<OffsetSize: OffsetSizeTrait> {
       data_type: DataType,
       nulls: Option<NullBuffer>,
       values: ArrayRef,
       value_offsets: OffsetBuffer<OffsetSize>,
   }
   ```
   For example, in the description of [this 
document](https://docs.rs/datafusion/latest/datafusion/common/arrow/array/struct.GenericListArray.html#representation),
 the value of the null list is `?`, it's not empty.
   
   In this situation, merely checking the `values` is unsafe, we must obtain 
valid values based on the `value_offsets`.
   
   
   ## What changes are included in this PR?
   - Fix bug in `unnest_generic_list`.
   
   ## Are these changes tested?
   Yes
   
   ## Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to