sunchao commented on code in PR #244:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/244#discussion_r1554654595
##########
spark/src/main/scala/org/apache/spark/shuffle/sort/RowPartition.scala:
##########
@@ -36,7 +36,10 @@ class RowPartition(initialSize: Int) {
def getRowSizes: Array[Int] = rowSizes.toArray
def reset(): Unit = {
- rowAddresses.clear()
- rowSizes.clear()
+ rowAddresses = null
Review Comment:
nit: why do we need to set this to null first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
