viirya commented on code in PR #245:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/245#discussion_r1554820004
##########
core/src/execution/datafusion/spark_hash.rs:
##########
@@ -422,15 +421,16 @@ mod tests {
Some(0.0),
Some(-0.0),
Some(-1.0),
+ None,
Review Comment:
Hmm, because you add null value, the test only tests the logic of null
input. Can you have it test both non-null and null paths?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
