wgtmac commented on code in PR #41037:
URL: https://github.com/apache/arrow/pull/41037#discussion_r1554996974
##########
cpp/src/parquet/encoding.cc:
##########
@@ -1192,10 +1192,13 @@ int PlainBooleanDecoder::DecodeArrow(
int values_decoded = num_values - null_count;
if (ARROW_PREDICT_FALSE(num_values_ < values_decoded)) {
// A too large `num_values` was requested.
- ParquetException::EofException();
+ ParquetException::EofException(
+ "A too large `num_values` was requested in PlainBooleanDecoder: remain
" +
+ std::to_string(num_values_) + ", requested: " +
std::to_string(values_decoded));
}
if (ARROW_PREDICT_FALSE(!bit_reader_->Advance(values_decoded))) {
- ParquetException::EofException();
+ ParquetException::EofException(
+ "PlainDecoder doesn't have enough values in bit_reader_");
Review Comment:
IMO, we should not expose variable name to user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
