alamb commented on code in PR #9969:
URL: https://github.com/apache/arrow-datafusion/pull/9969#discussion_r1555025763
##########
datafusion/core/tests/parquet/row_group_pruning.rs:
##########
@@ -447,17 +447,15 @@ macro_rules! int_tests {
};
}
-int_tests!(8, correct_bloom_filters: false);
-int_tests!(16, correct_bloom_filters: false);
-int_tests!(32, correct_bloom_filters: true);
-int_tests!(64, correct_bloom_filters: true);
+int_tests!(32);
Review Comment:
I think it would help to give future readers a hint here about why 8/16
aren't supported (rather than just an oversight):
```suggestion
// int8/int16 are incorrect:
https://github.com/apache/arrow-datafusion/issues/9779
int_tests!(32);
```
##########
datafusion/core/tests/parquet/row_group_pruning.rs:
##########
@@ -585,10 +583,8 @@ macro_rules! uint_tests {
};
}
-uint_tests!(8, correct_bloom_filters: false);
-uint_tests!(16, correct_bloom_filters: false);
-uint_tests!(32, correct_bloom_filters: true);
-uint_tests!(64, correct_bloom_filters: true);
+uint_tests!(32);
Review Comment:
Likewise here
```suggestion
// uint8/uint16 are incorrect:
https://github.com/apache/arrow-datafusion/issues/9779
uint_tests!(32);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
