joellubi commented on PR #1709:
URL: https://github.com/apache/arrow-adbc/pull/1709#issuecomment-2041659556

   > > It looks like the issue is purely that conda isn't finding `libduckdb` 
for windows which is odd....
   > 
   > because on windows, it's probably duckdb.dll; Windows doesn't use the lib 
prefix. Use just "duckdb" and [on Windows it'll add .dll for 
you](https://github.com/apache/arrow-adbc/blob/dff48ec3d6a1ab0a81811600358ec0144392a8df/c/driver_manager/adbc_driver_manager.cc#L116-L128)
 and [otherwise it'll prepend lib and append 
.so/.dylib](https://github.com/apache/arrow-adbc/blob/dff48ec3d6a1ab0a81811600358ec0144392a8df/c/driver_manager/adbc_driver_manager.cc#L149-L166)
   
   I tried just `duckdb` without `lib` and it works, which is nice. I think 
there's another issue though which is that there doesn't seem to even be a 
windows version hosted on 
[conda-forge](https://anaconda.org/conda-forge/libduckdb)...
   
   That said, I had been testing this with a [nightly 
release](https://duckdb.org/docs/installation/?version=main&environment=cplusplus&platform=linux&architecture=x86_64)
 of duckdb because some substrait issues were recently fixed but hadn't yet 
been included in a stable release. Testing against nightly might help surface 
issues/drift early. I suppose I could just download those in the github 
workflow and branch on the os / arch. Kind of complicated unfortunately. What 
do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to