vibhatha commented on code in PR #40340:
URL: https://github.com/apache/arrow/pull/40340#discussion_r1555124425
##########
java/vector/src/main/java/org/apache/arrow/vector/TypeLayout.java:
##########
@@ -347,11 +360,23 @@ public Integer visit(Binary type) {
return VARIABLE_WIDTH_BUFFER_COUNT;
}
+ @Override
+ public Integer visit(ArrowType.BinaryView type) {
Review Comment:
At the moment, I kept this unsupported and I already have created an issue
to follow up. I am also not sure about this. But if we think about the layout,
and keep the growing external buffer as K variable, the base minimum number of
buffers can be defined as 2, which is validity and view buffer. But I am not
sure if that actually make sense as layout should have that external buffer
represented in some way. Or can we include a callback-like thing to get the
precise value? But that is again a bit odd as layout supposed to be like an
enum-like class.
Not exactly sure what to do here.
// TODO: https://github.com/apache/arrow/issues/40934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
