jackwener commented on code in PR #9976:
URL: https://github.com/apache/arrow-datafusion/pull/9976#discussion_r1554954751
##########
datafusion/physical-expr/src/utils/mod.rs:
##########
@@ -265,10 +267,103 @@ mod tests {
use crate::PhysicalSortExpr;
use arrow_schema::{DataType, Field, Schema};
- use datafusion_common::{Result, ScalarValue};
+ use datafusion_common::{exec_err, DataFusionError, Result, ScalarValue};
+ use datafusion_expr::{
+ ColumnarValue, FuncMonotonicity, ScalarUDFImpl, Signature, Volatility,
+ };
use petgraph::visit::Bfs;
+ #[derive(Debug, Clone)]
+ pub struct TestScalarUDF {
Review Comment:
Should it bepub(super) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
