vibhatha commented on code in PR #40520:
URL: https://github.com/apache/arrow/pull/40520#discussion_r1555739391
##########
dev/archery/archery/linking.py:
##########
@@ -61,9 +63,77 @@ def list_dependency_names(self):
names.append(name)
return names
+ def _extract_symbols(self, symbol_info):
+ return [re.search(r'\S+$', line).group() for line in symbol_info if
line]
+
+ def _remove_weak_symbols(self, symbol_info):
+ return [line for line in symbol_info if not re.search(r'\s[Ww]\s',
line)]
+
+ def _capture_symbols(self, remove_symbol_versions, symbol_info):
+ if remove_symbol_versions:
+ symbol_info = [re.split('@@', line)[0] for line in symbol_info]
+ return symbol_info
+
+ def list_symbols_for_dependency(self, dependency,
remove_symbol_versions=False):
+ if dependency == 'linux-vdso.so.1':
+ return []
+ result = _nm.run('-D', dependency, stdout=subprocess.PIPE)
+ lines = result.stdout.decode('utf-8').splitlines()
+ lines = self._capture_symbols(remove_symbol_versions, lines)
+ return self._extract_symbols(lines)
+
+ def list_undefined_symbols_for_dependency(self, dependency,
+ remove_symbol_versions=False):
+ result = _nm.run('-u', dependency, stdout=subprocess.PIPE)
+ lines = result.stdout.decode('utf-8').splitlines()
+ lines = self._capture_symbols(remove_symbol_versions, lines)
+ lines = self._remove_weak_symbols(lines)
+ return self._extract_symbols(lines)
+
+ def extract_library_paths(self, file_path):
+ system = platform.system()
+ paths = {}
+ if system == 'Linux':
+ result = _ldd.run(file_path, stdout=subprocess.PIPE)
+ lines = result.stdout.decode('utf-8').splitlines()
+ for line in lines:
+ print(line)
+ match = re.search(r'(\S*) => (\S*)', line)
+ if match:
+ paths[match.group(1)] = match.group(2)
+ else:
+ match = re.search(r'(\S*) \(.*\)', line)
+ if match:
+ paths[match.group(1)] = match.group(1)
+ else:
+ raise ValueError(f"{system} is not supported")
+ return paths
+
+
+def _check_undefined_symbols(dylib, allowed):
+ # Check for undefined symbols
+ undefined_symbols =
dylib.list_undefined_symbols_for_dependency(dylib.path, True)
+ expected_lib_paths = dylib.extract_library_paths(dylib.path)
+ all_paths = list(expected_lib_paths.values())
+ print("All Paths")
+ print(all_paths)
Review Comment:
will remove the debug logs, I just added there just to see what I see in the
CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
