advancedxy commented on code in PR #206:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/206#discussion_r1555954298
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -238,6 +239,11 @@ class CometSparkSessionExtensions
val nativeOp = QueryPlanSerde.operator2Proto(op).get
CometScanWrapper(nativeOp, op)
+ case op if shouldApplyRowToColumnar(conf, op) =>
+ val cometOp = CometRowToColumnarExec(op)
+ val nativeOp = QueryPlanSerde.operator2Proto(cometOp).get
Review Comment:
`shouldApplyRowToColumnar ` already checks the output type of op. Only
supported types are allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
