keshen-msft commented on code in PR #41048:
URL: https://github.com/apache/arrow/pull/41048#discussion_r1556263015
##########
csharp/src/Apache.Arrow/Arrays/StringArray.cs:
##########
@@ -93,6 +100,30 @@ public string GetString(int index, Encoding encoding =
default)
}
}
+ public void Materialize(Encoding encoding = default)
Review Comment:
ok, concurrent Materialize() won't be safe because of lazy
materializedStringStore initialization. But if I declare
materializedStringStore as volatile and initialize using interlocked
compareexchange, it will be safe. What is your suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
