tustvold commented on code in PR #5605:
URL: https://github.com/apache/arrow-rs/pull/5605#discussion_r1556262768
##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -1366,7 +1366,13 @@ impl<T: ArrowTimestampType> PrimitiveArray<T> {
/// Construct a timestamp array with new timezone
pub fn with_timezone(self, timezone: impl Into<Arc<str>>) -> Self {
- self.with_timezone_opt(Some(timezone.into()))
+ let timezone_str = timezone.into().to_lowercase();
+
+ if timezone_str == "utc" {
Review Comment:
Is this necessary?
##########
arrow-array/src/timezone.rs:
##########
@@ -257,7 +257,12 @@ mod private {
/// An Arrow [`TimeZone`]
#[derive(Debug, Copy, Clone)]
pub struct Tz(FixedOffset);
-
+ impl Tz {
+ /// get timezone
+ pub fn get_time_zone(&self) -> FixedOffset {
Review Comment:
This will misbehave if the chrono-tz feature is enabled and we support
timezones with DST
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
