crepererum commented on code in PR #10009:
URL:
https://github.com/apache/arrow-datafusion/pull/10009#discussion_r1557396828
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -1240,7 +1294,10 @@ mod tests {
std::mem::drop(output_stream0);
// Now, start sending input
- input.wait().await;
+ let mut background_task = JoinSet::new();
+ background_task.spawn(async move {
+ input.wait().await;
+ });
Review Comment:
That goes for this and the other tests:
There is NO guarantee that the inputs to `RepartitionExec` are polled if you
never poll any of the outputs. Hence we need to move this barrier call into a
background task so it happens at the same time as the output poll below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
