alamb opened a new issue, #10011: URL: https://github.com/apache/arrow-datafusion/issues/10011
### Is your feature request related to a problem or challenge? One thing I finally understand while writing this is why @peter-toth added `transform_down_mut_with_subqueries` and similar functions. It is to mirror what is available on `TreeNode` (e.g. [`transform_down_mut`](https://docs.rs/datafusion/latest/datafusion/common/tree_node/trait.TreeNode.html#method.transform_down_mut))  While these functions have a nice symmetry I think their presence is more confusing than helpful and their use is quite limited (as can be seen by their implementation https://github.com/apache/arrow-datafusion/blob/eb05741e2167dec5df10a10c8435ebedbea6787d/datafusion/expr/src/logical_plan/plan.rs#L1392-L1445) I clearly was confused as well myself in the past when I tried to remove them: https://github.com/apache/arrow-datafusion/pull/9997 ### Describe the solution you'd like I think we should remove these functions in the name of a cleaner API ### Describe alternatives you've considered We can leave them ### Additional context I only finally realized what was going on while trying to document these functions: https://github.com/apache/arrow-datafusion/pull/10010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
