jorisvandenbossche commented on code in PR #40867:
URL: https://github.com/apache/arrow/pull/40867#discussion_r1557593104
##########
python/pyarrow/table.pxi:
##########
@@ -3389,20 +3389,25 @@ cdef class RecordBatch(_Tabular):
<CResult[shared_ptr[CArray]]>deref(c_record_batch).ToStructArray())
return pyarrow_wrap_array(c_array)
- def to_tensor(self, c_bool null_to_nan=False, MemoryPool memory_pool=None):
+ def to_tensor(self, c_bool null_to_nan=False, c_bool row_major=True,
MemoryPool memory_pool=None):
"""
Convert to a :class:`~pyarrow.Tensor`.
RecordBatches that can be converted have fields of type signed or
unsigned
- integer or float, including all bit-widths. RecordBatches with
validity bitmask
- for any of the arrays can be converted with ``null_to_nan``turned to
``True``.
- In this case null values are converted to NaN and signed or unsigned
integer
- type arrays are promoted to appropriate float type.
+ integer or float, including all bit-widths.
+
+ ``null_to_nan`` is ``False`` by default and this method will raise an
error in case
+ any nulls are present. RecordBatches with nulls
+ arrays can be converted with ``null_to_nan`` set to ``True``. In this
case
+ null values are converted to ``NaN`` and integer type arrays
+ are promoted to the appropriate float type.
Review Comment:
Formatting nit: can you re-flow this paragraph a bit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
