comphead commented on code in PR #9991: URL: https://github.com/apache/arrow-datafusion/pull/9991#discussion_r1557895178
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -3428,3 +3428,16 @@ SELECT LAST_VALUE(column1 ORDER BY column2 DESC) IGNORE NULLS FROM t; statement ok DROP TABLE t; + +# Test for IGNORE NULLS / ORDER BY not implemented +statement error DataFusion error: This feature is not implemented: IGNORE NULLS is not implemented for COUNT +SELECT COUNT(*) IGNORE NULLS FROM (values (1), (null), (2)); Review Comment: If its doable in parser we probably may want to revert those checks/tests from DF -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
